2.x: UnicastSubject fix onTerminate #4592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanniktech
commented
Sep 23, 2016
| @@ -184,7 +191,7 @@ public void onNext(T t) { | |||
| return; | |||
| } | |||
| if (t == null) { | |||
| onError(new NullPointerException()); | |||
| onError(new NullPointerException("onNext called with null. Null values are generally not allowed in 2.x operators and sources.")); | |||
There was a problem hiding this comment.
should not this throw immediately rather than trying to go through onError?
There was a problem hiding this comment.
Yeah, the spec mandates throwing on null input and I think the Processor TCK also expects it. I thought signalling NPE is more graceful with Subjects and FlowableProcessors and shuts down the streams as well whereas a thrown NPE may leave everybody hanging.
There was a problem hiding this comment.
Alright I'll leave the decision up to you. I'd prefer the fail early approach however delegating it down the stream also works. If you want me to change it I'll do so in a follow up PR.
akarnokd
approved these changes
Sep 23, 2016
Current coverage is 78.15% (diff: 66.66%)@@ 2.x #4592 diff @@
==========================================
Files 552 552
Lines 36247 36254 +7
Methods 0 0
Messages 0 0
Branches 5594 5595 +1
==========================================
+ Hits 28293 28335 +42
+ Misses 5944 5913 -31
+ Partials 2010 2006 -4
|
|
Leave this as is and I'll think about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.