2.x fix Flowable.create() not reporting null values properly, unify #4583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exception msg across
Current coverage is 78.04% (diff: 70.00%)@@ 2.x #4583 diff @@
==========================================
Files 552 552
Lines 36156 36184 +28
Methods 0 0
Messages 0 0
Branches 5574 5584 +10
==========================================
+ Hits 28209 28239 +30
- Misses 5924 5925 +1
+ Partials 2023 2020 -3
|
JakeWharton
approved these changes
Sep 22, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exception msg across
Reported on Stackoverflow.
There was no proper null check in the various emitters. I've also unified the message pattern across all
create()emitters.