1.x: make Completable.subscribe() report isUnsubscribed consistently #3707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1859,6 +1860,7 @@ public final Subscription subscribe(final Action0 onComplete) { | |||
| subscribe(new CompletableSubscriber() { | |||
| @Override | |||
| public void onCompleted() { | |||
| mad.unsubscribe(); | |||
There was a problem hiding this comment.
This one should be called after onComplete.call().
akarnokd
force-pushed
the
CompletableLambdaIsUnsubscribed1x
branch
2 times, most recently
from
58826fa
to
a086b4f
Compare
akarnokd
force-pushed
the
CompletableLambdaIsUnsubscribed1x
branch
from
a086b4f
to
00433f3
Compare
|
Updated. |
| } | ||
| mad.unsubscribe(); |
There was a problem hiding this comment.
Or just remove the above return?
There was a problem hiding this comment.
OnError calls it too, shouldn't call again after onError returns.
|
I see. 👍 |
akarnokd
added a commit
that referenced
this pull request
Feb 15, 2016
1.x: make Completable.subscribe() report isUnsubscribed consistently
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The empty and lambda-based
Completable.subscribe()returns aSubscriptionwhoseisUnsubscribedshould be consistent with the rest of the reactive objects by returning true if the sequence terminated (not just when one truly cancelled it).