Skip to content

1.1.0: promote Single + SingleSubscriber to Beta #3401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Oct 1, 2015

Based on votes, Single, SingleSubscriber and Observable.toSingle can now
be promoted to Beta state.

Based on votes, Single, SingleSubscriber and Observable.toSingle can now
be promoted to Beta state.
@akarnokd akarnokd added this to the 1.1 milestone Oct 1, 2015
@charliek
Copy link

charliek commented Oct 1, 2015

I've been a really big fan of Single in our codebase. It helps document the API, reason about our code base, and helps us eliminate cases where people don't properly plan for multiple items when terminating streams.

To date we've not hit any corner cases that I am aware of, but we've not been using it too heavily yet.

+1

@beckje01
Copy link

beckje01 commented Oct 1, 2015

I love Single it makes the API very understandable.

@dsvoronin
Copy link

will be so natural in Retrofit 2.0
but also starting to use it in our codebase as well

@passsy
Copy link
Contributor

passsy commented Oct 8, 2015

I'm using it since the first public @Experimental release and it makes Interfaces more understandable. My current Observable/Single ratio is 30/70

I hope all operators known from Observable will be promoted to public for Single such as defer and lift. Doing the following workaround seems unnecessary:

public Single doSomething() {
    return Single.just(..)
        .map(..)
        .toObservable() // to Observable because defer is private for Single
        .defer(...)
        .toSingle(); // back to Single because API says so
}

@artem-zinnatullin
Copy link
Contributor

@passsy I am planning to use Single in production for the same reason of clearer contract of the API (though I see some cons in this too), so I'll try to bring most useful operators (defer in the list) to the Single during this week, and I hope Rx team will merge and release them as part of 1.0.15.

@akarnokd akarnokd closed this Dec 3, 2015
@akarnokd akarnokd deleted the SinglePromote branch May 18, 2016 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants