Static core #323
Static core #323
Conversation
Conflicts: rxjava-core/src/main/java/rx/Observable.java rxjava-core/src/main/java/rx/observables/BlockingObservable.java rxjava-core/src/main/java/rx/subjects/PublishSubject.java
This adds support for the Groovy closure by adding extension methods that overload Action/Function.
- remove static methods that are not entry points (creators or combinatorial) - remove deprecated methods This change was done to: - Reduce the footprint of the API - Clarify the API so instance methods are preferred unless the static method is appropriate as an entry point - Remove duplicate method signatures (such as a buffer method) where the only difference was one was static. This actually causes issues at the bytecode level with dynamic languages since the only difference between them is a modifier making one of them static. Some dynamic languages have a hard time choosing between the two methods when both have the same signature.
The Observable class is huge by nature as it is the facade for all operators. Due to this it represents all functionality and should not have it's tests inside it. They are moved to /src/test/ so as to allow breaking them up into lots of individual classes.
…per/extends generics
Reactivate core tests and combineLatest
…et rxjava-clojure JAR generation unblocked
Groovy, Statics, Fixes
|
RxJava-pull-requests #205 FAILURE |
|
Sure, I'll try this out asap. |
|
Updating my rxjava-samples project to this worked fine. |
We considered it being <String, Action> but that is also awkward as it's not a real functional interface. Also because of type erasure extension methods aren't super helpful here as Map<String, Action> collides with Map<String, Closure>
Remove subscribe(Map<String, Object>) and cleanup Functions.from
|
Thank you @jmhofer for confirming Scala functionality. |
|
RxJava-pull-requests #206 FAILURE |
|
If anyone watching this project uses RxJava with Groovy, please build from this branch and test. |
|
Current status of this pull request is:
|
Added rx.lang.clojure.interop namespace with fn and action macros. Updated examples. Updated README.
Static core clj
|
RxJava-pull-requests #207 FAILURE |
|
We use some Scala on the server side, where we use Finagle and Twitter Futures (not RxJava), but I could test in a sandbox project if that helps. I will be travelling for 2 weeks starting Monday, but I'll try to find some time over the weekend! |
|
Thanks @mttkay Don't stress if you don't have time over the weekend, we've had enough confirmation of Scala functionality to move forward. Enjoy your trip! |
|
Thank you @daveray for the Clojure adaptor. I think we are getting close to this pull request being ready to merge into master... just some final testing. If anyone has final feedback before we move forward now is the time. |
|
Merging to master for final testing and release. |
Another take on Issues #204, #208.