Amb with backpressure support #1516
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RxJava-pull-requests #1437 SUCCESS |
| @@ -274,6 +275,10 @@ private AmbSubscriber(Subscriber<? super T> subscriber, int index, AtomicInteger | |||
| this.index = index; | |||
| } | |||
|
|
|||
| public void requestMore(long n) { | |||
There was a problem hiding this comment.
By default this Subscriber will request Long.MAX_VALUE up, since it doesn't do anything onStart. When I put printlns in the test, it shows how it gets a Long.MAX_VALUE request first:
1-requested: 9223372036854775807
2-requested: 9223372036854775807
requestMore: 3
1-requested: 3
requestMore: 3
2-requested: 3
Merged
|
Please take a look at #1533 which builds on top of your change. |
|
Close as done in #1533 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1475