-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.x: Remove/Hide Flowable BackpressureMode.NONE? #4643
Comments
The |
|
Yeah I see, hm. But isn't it kind of weird to create Flowable with no On 29 Sep 2016 5:12 pm, "David Karnok" notifications@github.com wrote:
|
So, what should we do about it? I still think that it's kind of weird to have such easily-available API that can and probably will be misused pretty often and as a result will lead to Closest semantic problem I can think of is
@akarnokd what if we add APIs to apply parametrized cc @JakeWharton, we've discussed that offline a little bit and I would like to invite you to discussion here. |
Either you supply a varargs of options or introduce 8+ overloads.
Here, the user puts in the mode parameter and is explicit. So if someone reports a MissingBackpressureException and posts a create(..., NONE), that's a clear indication of the user error. |
Yes, but I'm not sure that a lot of users will understand that And even worse that when you use already created |
Lot of users copy from examples and so far, almost all 2.x create examples used
If you wrote the |
Can't completely agree. Ok, what about renaming |
If you find a good name... |
Variants from my team: I really like |
UNSUPPORTED On Wed, Oct 5, 2016, 7:05 AM Artem Zinnatullin notifications@github.com
|
Alright, |
Closing via #4767 |
So, we have
Observable
for nbp streams andFlowable
for bp streams.What I'm afraid of is that a lot of users will do
Flowable.create(emitter, BackpressureMode.NONE)
ortoFlowable(BackpressureMode.NONE)
while in fact they should useObservable
.The only correct usage of
BackpressureMode.NONE
I see at the moment is RS interop sinceObservable
is not RS type (please share other valid cases that can't be changed toObservable
).I might be overworrying of course, so opinions of project members are very appreciated.
The text was updated successfully, but these errors were encountered: