Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Observable.doOnCompleted name match Completable.doOnComplete in 1.x #3700

Closed
zach-klippenstein opened this issue Feb 12, 2016 · 1 comment
Closed

Make Observable.doOnCompleted name match Completable.doOnComplete in 1.x #3700

zach-klippenstein opened this issue Feb 12, 2016 · 1 comment
Labels
Cleanup

Comments

@zach-klippenstein
Copy link

Observable has a doOnCompleted method (past tense), and Completable has doOnComplete (present tense). The 2.x branch changes Observable's method to be present tense. The 1.x branch can add alias the past tense method in Observable and deprecate it.

I'm happy to make the change if this is approved.
@akarnokd
Copy link
Member

Sure.

zach-klippenstein added a commit to zach-klippenstein/RxJava that referenced this issue Feb 12, 2016
@zach-klippenstein
1.x: alias Observable.doOnCompleted to doOnComplete to match Completa…
053a3e9 
…ble and 2x

Closes ReactiveX#3700.
zach-klippenstein added a commit to zach-klippenstein/RxJava that referenced this issue Feb 12, 2016
@zach-klippenstein
1.x: alias Observable.doOnCompleted to match Completable and 2x
a1e1a25 
Closes ReactiveX#3700.
@zach-klippenstein zach-klippenstein mentioned this issue Feb 12, 2016
Merged
zach-klippenstein added a commit to zach-klippenstein/RxJava that referenced this issue Feb 12, 2016
@zach-klippenstein
1.x: alias Observable.doOnCompleted to match Completable and 2x
3973b96 
Closes ReactiveX#3700.
zach-klippenstein added a commit to zach-klippenstein/RxJava that referenced this issue Feb 12, 2016
@zach-klippenstein
1.x: alias Observable.doOnCompleted to match Completable and 2x
82f5da5 
Closes ReactiveX#3700.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zach-klippenstein @akarnokd