Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accepting promise for forkJoin()? #507

Closed
kwonoj opened this issue Oct 12, 2015 · 6 comments
Closed

accepting promise for forkJoin()? #507

kwonoj opened this issue Oct 12, 2015 · 6 comments
Labels
help wanted Issues we wouldn't mind assistance with.

Comments

@kwonoj
Copy link
Member

kwonoj commented Oct 12, 2015

RxJS4's forkJoin accepts promise as well as observables

args (Arguments | Array): An array or arguments of Observable sequences or Promises to collect the last elements for.

while current implementation does not. Is this intended design to drop promise? If promise can be accepted, PR #506 might need to be updated to include it as well as updating implementation.

@benlesh
Copy link
Member

benlesh commented Oct 12, 2015

Debatable. As long as it doesn't affect performance, I'm okay with it.

@benlesh benlesh added the help wanted Issues we wouldn't mind assistance with. label Oct 15, 2015
@benlesh
Copy link
Member

benlesh commented Oct 15, 2015

forkJoin should also accept "lowercase-o" observables... Meaning any object with an [Symbol.observable] method on it that returns an object with a subscribe function that accepts an observer.

@kwonoj
Copy link
Member Author

kwonoj commented Oct 16, 2015

I'll try to add to accept promise as start with performance benchmarking.

@benlesh
Copy link
Member

benlesh commented Nov 5, 2015

@kwonoj I don't recall.. did this get done?

@kwonoj
Copy link
Member Author

kwonoj commented Nov 5, 2015

It's WIP in my stash, but haven't completed yet while creating other PRs. I'll complete and create PR.

@benlesh
Copy link
Member

benlesh commented Nov 5, 2015

No hurry. Just checking

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Issues we wouldn't mind assistance with.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants