Skip to content

Commit f59225b

Browse files
alexeaglekwonoj
authored andcommitted
fix(typings): don't expose PromiseConstructor dependency
closes #1270
1 parent 446ae95 commit f59225b

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

src/CoreOperators.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ export interface CoreOperators<T> {
8484
timeout?: (due: number | Date, errorToSend?: any, scheduler?: Scheduler) => Observable<T>;
8585
timeoutWith?: <R>(due: number | Date, withObservable: Observable<R>, scheduler?: Scheduler) => Observable<T> | Observable<R>;
8686
toArray?: () => Observable<T[]>;
87-
toPromise?: (PromiseCtor: PromiseConstructor) => Promise<T>;
87+
toPromise?: (PromiseCtor: typeof Promise) => Promise<T>;
8888
window?: (closingNotifier: Observable<any>) => Observable<Observable<T>>;
8989
windowCount?: (windowSize: number, startWindowEvery: number) => Observable<Observable<T>>;
9090
windowTime?: (windowTimeSpan: number, windowCreationInterval?: number, scheduler?: Scheduler) => Observable<Observable<T>>;

src/Observable.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ export class Observable<T> implements CoreOperators<T> {
129129
* @returns {Promise} a promise that either resolves on observable completion or
130130
* rejects with the handled error
131131
*/
132-
forEach(next: (value: T) => void, thisArg: any, PromiseCtor?: PromiseConstructor): Promise<void> {
132+
forEach(next: (value: T) => void, thisArg: any, PromiseCtor?: typeof Promise): Promise<void> {
133133
if (!PromiseCtor) {
134134
if (root.Rx && root.Rx.config && root.Rx.config.Promise) {
135135
PromiseCtor = root.Rx.config.Promise;
@@ -269,7 +269,7 @@ export class Observable<T> implements CoreOperators<T> {
269269
timeout: (due: number | Date, errorToSend?: any, scheduler?: Scheduler) => Observable<T>;
270270
timeoutWith: <R>(due: number | Date, withObservable: Observable<R>, scheduler?: Scheduler) => Observable<T> | Observable<R>;
271271
toArray: () => Observable<T[]>;
272-
toPromise: (PromiseCtor?: PromiseConstructor) => Promise<T>;
272+
toPromise: (PromiseCtor?: typeof Promise) => Promise<T>;
273273
window: (closingNotifier: Observable<any>) => Observable<Observable<T>>;
274274
windowCount: (windowSize: number, startWindowEvery: number) => Observable<Observable<T>>;
275275
windowTime: (windowTimeSpan: number, windowCreationInterval?: number, scheduler?: Scheduler) => Observable<Observable<T>>;

src/operator/toPromise.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import {root} from '../util/root';
22

3-
export function toPromise<T>(PromiseCtor?: PromiseConstructor): Promise<T> {
3+
export function toPromise<T>(PromiseCtor?: typeof Promise): Promise<T> {
44
if (!PromiseCtor) {
55
if (root.Rx && root.Rx.config && root.Rx.config.Promise) {
66
PromiseCtor = root.Rx.config.Promise;

0 commit comments

Comments
 (0)