Fix event source iterable #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 858
💛 - Coveralls |
This change fixes locked up event source iterable obervers which were waiting for their channels to be closed. The event source iterable, using a blocking strategy, could be notified that its context has been canceled and exit without closing waiting observers' channels. A deferred function which closes all observers was added to the event source iterable's go routine, thus ensuring that all the observers' channels were closed.
teivah
approved these changes
Apr 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes locked up event source iterable obervers which were
waiting for their channels to be closed. The event source iterable,
using a blocking strategy, could be notified that its context has been
canceled and exit without closing waiting observers' channels.
A deferred function which closes all observers was added to the event
source iterable's go routine, thus ensuring that all the observers'
channels were closed.