Use ViewAction1 in ViewAction.setText and setTextResource. #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return new Action1<CharSequence>() { | ||
| public static Action1<? super CharSequence> setText(TextView textView) { | ||
| return new ViewAction1<TextView, CharSequence>(textView) { | ||
|
|
There was a problem hiding this comment.
suuuuper nit: extra empty line!
hamidp
force-pushed
the
fixup-textview-actions
branch
from
35406da to
4299ccc
Compare
|
@JakeWharton Fixed! Thanks for catching it. I am super nitpicky about stuff like this. I can't wait until we get checkstyle going. |
|
I have preliminary checkstyle in #81 but blocked by other RxJava plugin nonsense. If I find the will (and time) I'll split it out so it can get in sooner. |
JakeWharton
added a commit
that referenced
this pull request
Nov 25, 2014
Use ViewAction1 in ViewAction.setText and setTextResource.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #85