Port library to RxJava 2. #316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
force-pushed
the
jw/two
branch
2 times, most recently
from
32ee3dc to
6c52a4c
Compare
| onDispose(); | ||
| } | ||
| }); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
nice spot. four space indent is such a waste of space!
JakeWharton
force-pushed
the
jw/two
branch
2 times, most recently
from
7130fb8 to
a89b4d2
Compare
Contributor
|
👍 |
Contributor
Author
|
I have removed the periodic implementation and disabled the tests. I'll pursue it post-merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #279. Closes #281.
@dlew @akarnokd @artem-zinnatullin