retain cycle when using didBecomeActiveSignal #43

Activity

1. jspahrsummers commented on Apr 6, 2015

   

   jspahrsummers

   on Apr 6, 2015

   Member

   More actions

   That sounds like a bug, if true. Could you please distill it down into a minimal test case? 🙏
2. jspahrsummers

   added

   bug

   on Apr 6, 2015
3. adriantofan commented on Apr 7, 2015

   

   adriantofan

   on Apr 7, 2015

   Author

   More actions

   Yes,
   Here is the code:

   @interface ViewController:UIViewController
   @property (nonatomic,strong,readwrite) RVMViewModel* viewModel;
   @end
   
   @implementation ViewController
   -(void)viewDidLoad{
     [super viewDidLoad];
     self.viewModel = [[RVMViewModel alloc] init];
     [[[[RACSignal
       combineLatest:@[
   /*A */                         self.viewModel.didBecomeActiveSignal]]
   /*B                            RACObserve(self.viewModel,active)]] */
       deliverOnMainThread]
       distinctUntilChanged]
       subscribeNext:^(RACTuple* x) {
         NSLog(@"...");
       }];
     self.viewModel.active = YES;
   }
   @end
   

   I would be happy to investigate further if you can give me any pointer about what might be wrong.

   Thank you,
   Adrian
4. ashfurrow commented on Apr 7, 2015

   

   ashfurrow

   on Apr 7, 2015

   Member

   More actions

   @adriantofan Is that a RACObserve inside another RACObserve? That may be the source of the issue.
5. adriantofan commented on Apr 7, 2015

   

   adriantofan

   on Apr 7, 2015

   Author

   More actions

   @ashfurrow no, that was a typo. Sorry about that
6. jspahrsummers commented on Apr 10, 2015

   

   jspahrsummers

   on Apr 10, 2015

   Member

   More actions

   Ah, so, didBecomeActiveSignal will send the view model whenever a change occurs. That won't automatically cause a cycle, but it could result in problems if you replay the signal (thus keeping the view model alive), or capture the sent value in a block or something.