Redeclare operations from RACStream with more precise ValueType #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ValueType information Since the operations built on RACStream primitives have an `instancetype` return value, the compiler assumes that they inherit the receiving signal’s `ValueType`. For operators like `map:`, this is almost always an incorrect assumption. As such, in cases where the `ValueType` of the result of the operation is not able to be inferred, the `ValueType` is erased in the result by returning `RACSignal *` with no `ValueType` information. Additionally, in cases where `instancetype` is a valid return type and no more precise `ValueType` information could be added to the method signature, the operation is not redeclared, since the compiler will assume the correct return type. Finally, in cases where more precise type information could be provided, the operators are redeclared as such.
mdiep
approved these changes
Nov 19, 2016
byohay
pushed a commit
to byohay/ReactiveObjC
that referenced
this pull request
Dec 14, 2021
…y-weak-var RACDelegateProxy: change property from unsafe_unretained to weak.
stuartofmine
pushed a commit
to stuartofmine/ReactiveObjC_2023
that referenced
this pull request
Oct 18, 2023
Redeclare operations from RACStream with more precise ValueType
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the operations built on
RACStreamprimitives have aninstancetypereturn value, the compiler assumes that they inherit the receiving signal’sValueTypewhen they are invoked onRACSignal. For operators likemap:, this is almost always an incorrect assumption. As such, in cases where theValueTypeof the result of the operation is not able to be inferred, theValueTypeis erased in the result by returningRACSignal *with noValueTypeinformation.Additionally, in cases where
instancetypeis a valid return type and no more preciseValueTypeinformation could be added to the method signature, the operation is not redeclared, since the compiler will assume the correct return types.Finally, in cases where more precise type information could be provided, the operators are redeclared as such.