Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop docker image build during PR and cleaned the docker CI file #119

Merged
merged 1 commit into from
May 10, 2023

Conversation

calvinp0
Copy link
Member

@calvinp0 calvinp0 commented May 3, 2023

No description provided.

@calvinp0 calvinp0 requested a review from kfir4444 May 3, 2023 15:35
@codecov-commenter
Copy link

codecov-commenter commented May 3, 2023

Codecov Report

Merging #119 (62810ff) into main (2de3b76) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
- Coverage   73.46%   73.40%   -0.07%     
==========================================
  Files          22       22              
  Lines        2891     2891              
  Branches      762      762              
==========================================
- Hits         2124     2122       -2     
- Misses        552      553       +1     
- Partials      215      216       +1     
Flag Coverage Δ
unittests 73.40% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
t3/settings/t3_submit.py 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@calvinp0 calvinp0 requested review from alongd and Lilachn91 May 4, 2023 11:09
@calvinp0 calvinp0 force-pushed the docker_image_CI branch from 62810ff to a152cfa Compare May 4, 2023 11:10
Copy link
Member

@alongd alongd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please rebase

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v1

- name: Debug
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove the debug step?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it isn't required for the main branch - I just needed it during the development

@calvinp0 calvinp0 merged commit 3492f09 into main May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants