Skip to content

Conversation

@mjohnson541
Copy link
Collaborator

This provides functionality for analyzing why a mechanism simulation crashed in terms of reactions, kinetics and thermochemistry. Also adds some functionality for analyzing collision limit violations, but only relative to H+H->H2 since sigma and epsilon often aren't available.

@codecov
Copy link

codecov bot commented Apr 21, 2021

Codecov Report

Merging #99 (be01846) into master (ede84eb) will decrease coverage by 1.54%.
The diff coverage is 0.00%.

❗ Current head be01846 differs from pull request most recent head b91b6a3. Consider uploading reports for the commit b91b6a3 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
- Coverage   55.45%   53.90%   -1.55%     
==========================================
  Files          25       26       +1     
  Lines        4660     4794     +134     
==========================================
  Hits         2584     2584              
- Misses       2076     2210     +134     
Impacted Files Coverage Δ
src/Debugging.jl 0.00% <0.00%> (ø)
src/ReactionMechanismSimulator.jl 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ede84eb...b91b6a3. Read the comment docs.

@mjohnson541
Copy link
Collaborator Author

@hwpang can you review this? It functions for single domain simulations, it's quite useful and other people have asked about getting access to it. I would've liked to clean up the collision limit analysis and add tests, but I don't really know when I might have time to devote to that...with the anniversary of the PR coming up I figure its better if we just get in what we have before this tool gets forgotten and never makes it in. It's certainly easier to upgrade this in the future than start from scratch.

this function analyzes the rates and dydt to identify reactions
and thermochemistry that seems to be contributing to the failure
either through contributing NaNs or high fluxes relative to the
rest of the simulation
Ideally this would produce comparable output to analyzecrash
But for now it just prints out its own report
@mjohnson541
Copy link
Collaborator Author

replaced by #174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants