-
Notifications
You must be signed in to change notification settings - Fork 154
Refit Intra R Add Endo/Exocyclic Rate Rules #570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lily90502
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me
|
For completeness, I actually refit these reaction families when rebasing and pushing using a better list of thermo libraries. The list I used is This is the same lists that are given by default in our ATG notebook as well as our ATG script but I also appended my thermo libraries to the front which have very good calculations. I made a mistake the first time I pushed this branch in that I only used |
This library contains species participating in reactions relevant to heavy oil pyrolysis mechanisms
This value was previously estimated using group additivity. Now it is calculated with TST after doing conformer search and 1D rotor scans
amarkpayne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @kspieks ! I'll merge this in as soon as the tests pass
|
Merged as both checks passed |
This PR adds 1 training reaction to each of the
Intra_R_Add_EndocyclicandIntra_R_Add_Exocyclicreaction families and also refits the rate rules. All calculations were done atCCSD(T)-F12a/cc-pVDZ-F12//ωB97X-D3/def2-TZVPand include conformer searches and 1D rotor scans. The notebooks for refitting the rate rules as well as a slide deck that summarizes the improved rate estimate for these reactions is included in the zip file below.The training reaction added to
Intra_R_Add_Exocyclicbrings substantial improvements. Previously, the rate rules gave an estimate for k(T=673K) that was over 1000x smaller than the actual rate calculated from TST.The training reaction added to
Intra_R_Add_Endocyclicbrings minor improvements. Previously, this training reaction, which just came from group additivity, gave an estimate for k(T=673K) that was ~5x smaller than the actual rate calculated from TST. Note that since the product for this training reaction is chiral, the A-factor had to be multiplied by 2 since the reactant can attack itself from either the top or the bottom (both options are possible and equally likely).Hopefully these new training reactions and rate rules improve people's mechanisms :)
20220321.zip