Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable bitcode + chroma threshold #78

Merged
merged 2 commits into from
Jan 31, 2022
Merged

Enable bitcode + chroma threshold #78

merged 2 commits into from
Jan 31, 2022

Conversation

ramicaza
Copy link
Contributor

@ramicaza ramicaza commented Jan 11, 2022 •
edited
Loading

This is the corresponding PR for this. Please see that PR to learn of the changes in this one.

Note: had to remove target 'ViroReact_release_tests' from the Podfile, not sure what that was about...

robertjcolley
robertjcolley reviewed Jan 31, 2022
View reviewed changes
Copy link
Collaborator

@robertjcolley robertjcolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noticed that there are some binary files being included in this PR. Is this necessary?

robertjcolley
robertjcolley reviewed Jan 31, 2022
View reviewed changes
Copy link
Collaborator

@robertjcolley robertjcolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also what are the hourglass files for? I assume they are a model which snuck their way in - or some sort of loading model.

robertjcolley
robertjcolley reviewed Jan 31, 2022
View reviewed changes
Copy link
Collaborator

@robertjcolley robertjcolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there sound issues being fixed in this PR as well?

I have some hesitations about including ios/dist unless we need to. Why are these being included?

doranteseduardo
doranteseduardo approved these changes Jan 31, 2022
View reviewed changes
Copy link
Member

@doranteseduardo doranteseduardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, my only concern is the binaries size increasing around 250%, but I think is not a big deal.

@doranteseduardo
Copy link
Member

Is there sound issues being fixed in this PR as well?

I have some hesitations about including ios/dist unless we need to. Why are these being included?

As bitcode is now enabled, the ViroCore has to be rebuild.

@doranteseduardo doranteseduardo merged commit 5f6522a into ReactVision:main Jan 31, 2022
@robertjcolley robertjcolley mentioned this pull request Feb 1, 2022
Merged
6 tasks
@robertjcolley robertjcolley added this to the v2.23.0 milestone Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertjcolley robertjcolley robertjcolley left review comments

@doranteseduardo doranteseduardo doranteseduardo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ramicaza @doranteseduardo @robertjcolley