fix: add support for resolving Viro Android path in workspace environments#493
Open
busybox11 wants to merge 1 commit into
Open
fix: add support for resolving Viro Android path in workspace environments#493busybox11 wants to merge 1 commit into
busybox11 wants to merge 1 commit into
Conversation
bd46157 to
b847384
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently, Viro's Expo config plugin hardcodes
../node_modules/@reactvision/react-viro/android/...when writing the Android project paths intosettings.gradle. This assumes react-viro is installed in the app's ownnode_modules.In a monorepo (pnpm/yarn/npm/... workspace), the package is hoisted to the workspace root instead, so those paths don't exist and the Gradle build fails with:
What changed
I have added support for resolving react-viro's real install location instead of assuming it's app-local.
withViroSettingsGradlenow usesrequire.resolve("@reactvision/react-viro/package.json", { paths: [projectRoot] })and emits the path relative to the Android project root.If resolution fails it falls back to the original
../node_modules/...string, so nothing changes for flat installs.Why this is helpful
../node_modules/@reactvision/react-viro/android.Testing
tsc --noEmitpasses.../node_modules/@reactvision/react-viro/android(unchanged).This PR was made against
developto make sure that there wasn't already a fix in the works. Can reopen againstmaininstead, feel free to let me know if this is necessary.