Integrate RVCA and React Vision Providers with Enhancements#448
Open
doranteseduardo wants to merge 32 commits intomainfrom
Open
Integrate RVCA and React Vision Providers with Enhancements#448doranteseduardo wants to merge 32 commits intomainfrom
doranteseduardo wants to merge 32 commits intomainfrom
Conversation
…y in the New Architecture
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a major release (v2.53.0) with significant new features, breaking changes, and numerous bug fixes. The most impactful update is a complete re-architecture of the
ViroARPlaneSelectorcomponent to a scene-event-driven model, requiring explicit forwarding of AR anchor events from the parentViroARScene. The release also adds support for the ReactVisionCCA cloud and geospatial anchor provider, new depth sensor options, and substantial enhancements to shader modifier capabilities. In addition, a new Android HTTP client (RVHttpClient) is introduced for cloud anchor operations, and several critical bugs are addressed across AR plane selection, 3D model rendering, and platform-specific APIs.Breaking Changes:
ViroARPlaneSelectornow requires explicit forwarding of anchor events fromViroARScenevia a ref; the previous self-contained usage is no longer supported.Major Feature Additions:
ViroARSceneNavigator:depthEnabled,depthDebugEnabled, andpreferMonocularDepth, providing improved depth data access and debugging. [1] [2]sampler2Duniforms, runtime texture updates, custom varyings, scene depth and camera texture access, and deterministic priority ordering.RVHttpClient, for JSON, binary, and multipart HTTP requests, used by the ReactVisionCCA integration.Bug Fixes and Improvements:
ViroARPlaneSelectorincluding ghost planes, incorrect selection opacity, duplicated children, improper cleanup of removed planes, and correct handling ofonPlaneDetectedreturn values.Internal/Integration:
VRTARSceneNavigatorto import additional Android system classes for location and sensor management, supporting new geospatial features.References:
[1] [2] [3] [4]