Skip to content

Fix pause/cancel bug when chained with then/success/catch. #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 5, 2014

Conversation

inamiy
Copy link
Member

@inamiy inamiy commented Dec 5, 2014

This pull request will allow chained task to pause/cancel its parent task.

For example,

let task3 = task1.then { ...
    return task2
}

task3.pause() will invoke:

  • task1.pause() if task1 is still running
  • task2.pause() if task1 is either fulfilled or rejected & task2 is still running

and so will cancel().

FYI, bug 568e012 was discovered when I was adding new retryable feature try() in 9438564 #9.

inamiy added a commit that referenced this pull request Dec 5, 2014
Fix pause/cancel bug when chained with then/success/catch.
@inamiy inamiy merged commit 7570ac0 into retryable Dec 5, 2014
@inamiy inamiy deleted the async-chained-pause-cancel branch December 5, 2014 13:32
inamiy added a commit that referenced this pull request Dec 25, 2014
…ault, but do so only in try() method instead (partially reverting #10 d489ef9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant