Skip to content

Conversation

@skyfe79
Copy link
Member

@skyfe79 skyfe79 commented Sep 19, 2021

Motivation

  • We need to track the lifetime of the component. For example, when we have video content, we need to play or stop the video depending on the component life.

Changes

  • rename DataSource to ListKitDataSource.
  • Define func willDisplay(content: Content) on Component.
  • Define func didEndDisplay(content: Content) on Component.
  • Change visibility of AnyComponent from internal to public.
  • Define ComponentLifeTimeTrackingDelegate to track the lifetime of the component and notify it to the component.

@skyfe79 skyfe79 added the enhancement New feature or request label Sep 19, 2021
@skyfe79 skyfe79 self-assigned this Sep 19, 2021
@skyfe79 skyfe79 merged commit 3c18186 into main Sep 19, 2021
@skyfe79 skyfe79 deleted the feature/support-tracking-lifetime-of-component branch September 19, 2021 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants