Skip to content

feat(Spotify): Bump librespot to 1.6.6-SNAPSHOT + set playback to local #5668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Aug 20, 2025

Conversation

Emiferpro
Copy link

This patch fixes the crash when selecting revanced as output. Also it makes android think we are playing to the phone speakers and not to a remote device, allowing us to change the volume normally

Signed-off-by: emiferpro <emiferpro@gmail.com>
Signed-off-by: emiferpro <emiferpro@gmail.com>
Co-authored-by: LisoUseInAIKyrios <118716522+LisoUseInAIKyrios@users.noreply.github.com>
Copy link
Member

@brosssh brosssh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, I'm still not convinced by the fingerprint but it might be the most efficient way to fingerprint this method.

@brosssh
Copy link
Member

brosssh commented Aug 19, 2025

Also I still see the files which shouldn't have been committed.

@Emiferpro
Copy link
Author

Also I still see the files which shouldn't have been committed.

I really don't know why they are being committed, an IDEA issue i assume.

@Emiferpro
Copy link
Author

Emiferpro commented Aug 19, 2025

without the returns("V"):

SEVERE: "Force Local Playback" failed:
app.revanced.patcher.patch.PatchException: Could not find instruction index
        at app.revanced.util.BytecodeUtilsKt.indexOfFirstInstructionOrThrow(BytecodeUtils.kt:625)

seems to hit a different method

@brosssh
Copy link
Member

brosssh commented Aug 19, 2025

So it's matching another fingerprint. It's good like this then.

@Emiferpro
Copy link
Author

oh fuck the local.properties. ill delete it

Signed-off-by: emiferpro <emiferpro@gmail.com>
Signed-off-by: emiferpro <emiferpro@gmail.com>
@LisoUseInAIKyrios LisoUseInAIKyrios merged commit 45eff36 into ReVanced:fix/spotify/spoof-client Aug 20, 2025
Copy link

welcome bot commented Aug 20, 2025

Thank you for contributing to ReVanced. Join us on Discord to receive a role for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants