-
-
Notifications
You must be signed in to change notification settings - Fork 510
feat(Spotify): Bump librespot to 1.6.6-SNAPSHOT + set playback to local #5668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Spotify): Bump librespot to 1.6.6-SNAPSHOT + set playback to local #5668
Conversation
patches/src/main/kotlin/app/revanced/patches/spotify/misc/volume/Fingerprints.kt
Outdated
Show resolved
Hide resolved
patches/src/main/kotlin/app/revanced/patches/spotify/misc/volume/ForceLocalPlaybackPatch.kt
Outdated
Show resolved
Hide resolved
patches/src/main/kotlin/app/revanced/patches/spotify/misc/volume/ForceLocalPlaybackPatch.kt
Outdated
Show resolved
Hide resolved
patches/src/main/kotlin/app/revanced/patches/spotify/misc/volume/ForceLocalPlaybackPatch.kt
Outdated
Show resolved
Hide resolved
patches/src/main/kotlin/app/revanced/patches/spotify/misc/volume/ForceLocalPlaybackPatch.kt
Outdated
Show resolved
Hide resolved
patches/src/main/kotlin/app/revanced/patches/spotify/misc/volume/ForceLocalPlaybackPatch.kt
Outdated
Show resolved
Hide resolved
patches/src/main/kotlin/app/revanced/patches/spotify/misc/volume/Fingerprints.kt
Show resolved
Hide resolved
patches/src/main/kotlin/app/revanced/patches/spotify/misc/volume/Fingerprints.kt
Outdated
Show resolved
Hide resolved
patches/src/main/kotlin/app/revanced/patches/spotify/misc/volume/ForceLocalPlaybackPatch.kt
Outdated
Show resolved
Hide resolved
patches/src/main/kotlin/app/revanced/patches/spotify/misc/volume/ForceLocalPlaybackPatch.kt
Outdated
Show resolved
Hide resolved
…ding Fingerprints.kt
…tInstructionsOrThrow instead of instructions.indexOfFirst
patches/src/main/kotlin/app/revanced/patches/spotify/misc/volume/Fingerprints.kt
Show resolved
Hide resolved
patches/src/main/kotlin/app/revanced/patches/spotify/misc/volume/ForceLocalPlaybackPatch.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: emiferpro <emiferpro@gmail.com>
patches/src/main/kotlin/app/revanced/patches/spotify/misc/volume/ForceLocalPlaybackPatch.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: emiferpro <emiferpro@gmail.com>
patches/src/main/kotlin/app/revanced/patches/spotify/misc/volume/ForceLocalPlaybackPatch.kt
Show resolved
Hide resolved
patches/src/main/kotlin/app/revanced/patches/spotify/misc/volume/ForceLocalPlaybackPatch.kt
Outdated
Show resolved
Hide resolved
patches/src/main/kotlin/app/revanced/patches/spotify/misc/volume/ForceLocalPlaybackPatch.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: LisoUseInAIKyrios <118716522+LisoUseInAIKyrios@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, I'm still not convinced by the fingerprint but it might be the most efficient way to fingerprint this method.
patches/src/main/kotlin/app/revanced/patches/spotify/misc/volume/Fingerprints.kt
Outdated
Show resolved
Hide resolved
Also I still see the files which shouldn't have been committed. |
I really don't know why they are being committed, an IDEA issue i assume. |
without the returns("V"):
seems to hit a different method |
So it's matching another fingerprint. It's good like this then. |
oh fuck the local.properties. ill delete it |
Signed-off-by: emiferpro <emiferpro@gmail.com>
Signed-off-by: emiferpro <emiferpro@gmail.com>
patches/src/main/kotlin/app/revanced/patches/spotify/misc/volume/ForceLocalPlaybackPatch.kt
Outdated
Show resolved
Hide resolved
Thank you for contributing to ReVanced. Join us on Discord to receive a role for your contribution. |
This patch fixes the crash when selecting revanced as output. Also it makes android think we are playing to the phone speakers and not to a remote device, allowing us to change the volume normally