-
-
Notifications
You must be signed in to change notification settings - Fork 843
feat: Add periodic background bundle updates #2561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: compose-dev
Are you sure you want to change the base?
feat: Add periodic background bundle updates #2561
Conversation
6cd95db
to
81c78ef
Compare
I feel like time options less than a day shouldn't be available, as it would encourage users to immediately update when updates drop Wouldn't this be better if it were push notifications instead? The patch bundle source would be needed to host something but it would prevent the ReVanced Manager from having to poll for updates so frequently if we're going to include such little times |
Push notifications requires some kind of web socket server from what I understand. Poll works fine thanks to Cloudflare caching as well as the /version response which is small |
Current behavior: Record_2025-05-23-22-50-36.mp4 |
Time options and strings shown to the user can (and should) be adjusted. For now the time options are like this because it's easier for me to understand if the job is running correctly. |
To double check if the Android11Dialog is still shown correctly
d155c43
to
320823b
Compare
If the user doesn't wish to be notified of the bundle update then no background polling should happen, the bundles should be updated on app launch in that case |
This is still WIP, but I open the PR to both get feedback and to keep track of what I'm doing.
Feature:
Basically what is described here #2189: A scheduled job will run each X time (choosable by the user); it will check if an update is available for every remote bundle. A bundle can be excluded by deselecting the "Search for updates" toggle in the bundle settings. If an update was found, send a push notification (if permission were granted, else do not run the job).
Edit:
I've removed the TODO list since it would contains too many item now, I've made too many changes :^). I'll provide a video explaining what I did.
Open points:
Does it still make sense to have the auto update on app opening? Should that send a notification as well if it updates a bundle?Edit: Yes. The bundles are going to be updated still on app opening, while the search will be in the backgroundAny feedback is appreciated :).