Skip to content

fix: Use device locale when no preference is set (Issue #2478) #2483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025

Conversation

3chase
Copy link
Contributor

@3chase 3chase commented Apr 15, 2025

This change sets the language to the saved locale, if none it sets to the device locale, and uses English as a fallback

@3chase 3chase changed the title Bug Fix: Use device locale when no preference is set (Issue #2478) fix: Use device locale when no preference is set (Issue #2478) Apr 16, 2025
@validcube validcube self-requested a review April 17, 2025 09:45
@validcube validcube linked an issue Apr 17, 2025 that may be closed by this pull request
4 tasks
Copy link
Contributor

⚒️ Build status

🧪 Workflow triggered by: validcube

Details: Job execution 14515094707 / attempt 1!

⚙️ Workflow Steps

Step Status
Get dependencies success
Generate translations success
Generate code files success
Build success

⚙️ Workflow Configuration

Parameter Value
App flavor release
Flutter version 3.29.x
Flutter channel stable

Copy link
Member

@validcube validcube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥞 LGTM! (Tested)

Thanks

@validcube validcube merged commit f79aa9e into ReVanced:dev Apr 17, 2025
github-actions bot pushed a commit that referenced this pull request Apr 17, 2025
## [1.24.1-dev.5](v1.24.1-dev.4...v1.24.1-dev.5) (2025-04-17)

### Bug Fixes

* Use device locale when no preference is set ([#2483](#2483)) ([f79aa9e](f79aa9e))
github-actions bot pushed a commit that referenced this pull request Jun 27, 2025
# [1.25.0](v1.24.0...v1.25.0) (2025-06-27)

### Bug Fixes

* "Save patched app" attempts to copy APK when patching fails ([#2565](#2565)) ([bdb0317](bdb0317))
* Correct supported required patch option types  ([#2475](#2475)) ([cde3f8d](cde3f8d))
* Crash using when Integer type in Patch Options ([#2453](#2453)) ([05575cc](05575cc))
* Fix installation being cancelled at installation by not prematurely deleting patched APK  ([#2490](#2490)) ([dedcb3c](dedcb3c))
* Log errors and warnings when compiling resources ([5c7d52c](5c7d52c))
* Nearly all rare cases of GPU renderer issues, and allow building on manager again ([#2602](#2602)) ([21ceada](21ceada))
* Obscure Flutter Impeller renderer bugs ([a5e909c](a5e909c))
* Unable to Share Logs due to missing ProGuard rules ([#2474](#2474)) ([915ec0e](915ec0e))
* Use device locale for app language (Default to English) ([#2488](#2488)) ([3074766](3074766))
* Use device locale when no preference is set ([#2483](#2483)) ([f79aa9e](f79aa9e))

### Features

* Add toggle to use pre-releases ([#2485](#2485)) ([89b48ce](89b48ce))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Language is always set to English on launch System language feat: add languages in app, and make manager use android default language
2 participants