Skip to content

Edit Argument Labels #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Edit Argument Labels #109

wants to merge 1 commit into from

Conversation

@TaeJoongYoon
Copy link
Member

@TaeJoongYoon TaeJoongYoon commented Nov 8, 2018

I edit functions in Router name and arguments according to API Design Guidelines

// From
routingActionsForTransitionFrom(_ oldRoute:,newRoute:)
// To
routingActionsForTransition(from oldRoute:,to newRoute:)

// From
routableIndexForRouteSegment(_ segment:)
// To
routableIndex(for segment:)

@DivineDominion
Copy link
Contributor

DivineDominion commented May 20, 2019

@TaeJoongYoon can you rebase/merge the current master into your fork so we have a common base?

@TaeJoongYoon
Copy link
Member Author

TaeJoongYoon commented May 20, 2019

I'm so sorry.

I'm not good at git rebase so I deleted my PR repository.

I re-PR #116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TaeJoongYoon @DivineDominion