Repository navigation
Feat/28 message bubble component - #77
BezkorovainaYuliia wants to merge 14 commits into
Conversation
….tsx MessageBubble.types.ts is defined Without style and logic
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
| }, | ||
| }); | ||
|
|
||
| export const messageBubbleTimestampStyles = tv({ |
There was a problem hiding this comment.
Would it make sense to combine these using slots? Since both elements share the own variant, a single tv call with slots would keep the JSX cleaner.
There was a problem hiding this comment.
@payam-sharifi yes you are right. I change this
| return ( | ||
| <div className={messageBubbleStyles({ own })}> | ||
| <p>{text}</p> | ||
| {timestamp && <time className={messageBubbleTimestampStyles({ own })}>{timestamp}</time>} |
There was a problem hiding this comment.
If we combine the styles into slots, we can pass { own } just once here instead of calling two separate style functions.
…we have only one style Edit MessageBubble because of style
BezkorovainaYuliia
left a comment
BezkorovainaYuliia
left a comment
There was a problem hiding this comment.
I edit style
|
@fabiorodriguesdev i have some error with Vercel. I don't know why? 😔 |
|
Hi! The failing Vercel check on this PR isn't caused by your changes. Every preview was running migrations against the production database, and one stuck migration there broke all previews (Prisma error That's fixed in #83: previews now have their own database, separate from production. To get a green preview, please update your branch with git fetch origin
git merge origin/main
git pushOne rule to keep in mind from now on: never edit, rename or regenerate a migration once it has been pushed; add a new one instead. Details are in ARCHITECTURE.md. |
|
@denniesia @payam-sharifi @albsbz can someone pls merge my branch. |
This branch had an error being deployed
5 participants
I have done my part. It's MessageBubble components.