Introduce datatable.unique.names policy for duplicate handling in setnames() #4044#7647
Open
Introduce datatable.unique.names policy for duplicate handling in setnames() #4044#7647
Conversation
|
No obvious timing issues in HEAD=issuenight Generated via commit 88085d1 Download link for the artifact containing the test results: ↓ atime-results.zip
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

closes #4044
This PR introduces a configurable policy for handling duplicate column names created by setnames().
Changes introduced:
Added a new global option datatable.unique.names (default: "off") to preserve backward compatibility.
Supported policies:
Added a centralized helper process_name_policy() in utils.R to handle duplicate detection and enforcement.
Integrated the policy check into setnames() before reference updates to ensure keys and indices are not corrupted in "error" or "rename" modes.
hi @ben-schwen , when you have time could you please take a look?
thanks.