Skip to content

Conversation

@badasahog
Copy link
Contributor

Hopefully no conflicts?

@badasahog badasahog requested a review from tdhock as a code owner July 31, 2025 12:44
@codecov
Copy link

codecov bot commented Jul 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.77%. Comparing base (d875823) to head (c490a4e).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7232   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files          81       81           
  Lines       15241    15243    +2     
=======================================
+ Hits        15055    15057    +2     
  Misses        186      186           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

  • HEAD=IntegerOutline stopped early for DT[by,verbose=TRUE] improved in #6296
    Comparison Plot

Generated via commit c490a4e

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 5 minutes and 0 seconds
Installing different package versions 9 minutes and 58 seconds
Running and plotting the test cases 2 minutes and 36 seconds

@tdhock
Copy link
Member

tdhock commented Jul 31, 2025

great thanks

@tdhock tdhock merged commit 8dff81f into master Jul 31, 2025
12 checks passed
Comment on lines +108 to +109
SEXP ans = chmatch(x, table, -1);
PROTECT(ans);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor style note: since PROTECT() returns its argument, feel free to use the <type> <name> = PROTECT(<expression>) idiom when PROTECT(<name> = <expression>) is not applicable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants