Skip to content

add french version of datatable-joins.Rmd #7151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 15, 2025
Merged

Conversation

ChristianWia
Copy link
Contributor

aligned on last version of June23, 2025 data.table/vignettes/datatable-joins.Rmd

aligned on last version of June23, 2025 data.table/vignettes/datatable-joins.Rmd
@ChristianWia ChristianWia requested a review from a team as a code owner July 10, 2025 13:08
Copy link

codecov bot commented Jul 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.77%. Comparing base (8b1e3f9) to head (3b64d26).
Report is 18 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7151      +/-   ##
==========================================
+ Coverage   98.50%   98.77%   +0.26%     
==========================================
  Files          81       81              
  Lines       15019    15185     +166     
==========================================
+ Hits        14795    14999     +204     
+ Misses        224      186      -38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MichaelChirico MichaelChirico added the translation issues/PRs related to message translation projects label Jul 10, 2025
Copy link
Member

@MichaelChirico MichaelChirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Magnifique!! Merci beaucoup!

(I will leave it pending for now in case any other reviewer wants to weigh in on the actual translation)

@MichaelChirico
Copy link
Member

About how to do relative linking... I see only this in Russian:

package="data.table")`](../datatable-keys-fast-subset.html).

I confirmed that link WAI on the rendered version: https://rdatatable.gitlab.io/data.table/articles/ru/datatable-intro.html

Copy link

@emaigne emaigne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @ChristianWia for the translation. I put some comments and propositions of rephrasing.

corrected: remark taken into account L 89-92  monday friday....
corrected relative path to _translation_links.R
@ChristianWia
Copy link
Contributor Author

ChristianWia commented Jul 12, 2025

{r echo=FALSE, file='../_translation_links.R'} or {r, echo=FALSE, file='../_translation_links.R'} do we put a ',' or not after the 'r ' ?

@MichaelChirico
Copy link
Member

{r echo=FALSE, file='../_translation_links.R'} or {r, echo=FALSE, file='../_translation_links.R'} do we put a ',' or not after the 'r ' ?

I know we need the ',' in litedown, it's maybe optional in knitr?

@ChristianWia
Copy link
Contributor Author

ChristianWia commented Jul 14, 2025

{r echo=FALSE, file='../_translation_links.R'} or {r, echo=FALSE, file='../_translation_links.R'} do we put a ',' or not after the 'r ' ?

I know we need the ',' in litedown, it's maybe optional in knitr?

Next week i will try this form on my desktop with litedown and knitr to see if we are still compliant.

results attached to => #6583

FR related vignettes are supposed to be accessed in the same directory
@MichaelChirico
Copy link
Member

@tdhock I will let you merge when you are ready

@tdhock
Copy link
Member

tdhock commented Jul 15, 2025

I did a local render and it looks good, thanks very much!

@tdhock tdhock merged commit 17bdb4e into master Jul 15, 2025
11 checks passed
@MichaelChirico MichaelChirico deleted the ChristianWia-patch-1 branch July 15, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation issues/PRs related to message translation projects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants