-
Notifications
You must be signed in to change notification settings - Fork 1k
Remove partial argument usage #6855 #6870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove partial argument usage #6855 #6870
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6870 +/- ##
=======================================
Coverage 98.59% 98.59%
=======================================
Files 79 79
Lines 14660 14660
=======================================
Hits 14454 14454
Misses 206 206 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aitap
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested by re-rendering with options(warnPartialMatchArgs=TRUE, warn=2).
|
Ideally, we remove partial arguments from all vignettes in one go, right? |
|
There could be more in non-executable chunks, but in my tests, only
data.table-reshape.Rmd previously failed with
options(warnPartialMatchArgs=TRUE, warn=2).
|
You are right, I just manually build all vignettes with |
|
I have removed partial matching in the reshaping vignette since it was causing build failures with options(warnPartialMatchArgs=TRUE, warn=2). The other instances in comments and tests are either intentional or not causing any issues. |
|
Thank you @Mukulyadav2004!! |
Closes #6855
This PR replaces partial argument names (id, fun.agg, measure) with their full names (id.vars, fun.aggregate, measure.vars) in the following vignettes for improved clarity and consistency:
->vignettes/data.table-reshape.Rmd
->vignettes/fr/data.table-reshape.Rmd
->vignettes/ru/data.table-reshape.Rmd
Additionally, these changes ensure better alignment with the surrounding text for improved coherence.
@MichaelChirico, please review when you have time. Thank you!