-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gcc not found #6578
gcc not found #6578
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6578 +/- ##
==========================================
- Coverage 98.62% 98.60% -0.02%
==========================================
Files 79 79
Lines 14450 14516 +66
==========================================
+ Hits 14251 14314 +63
- Misses 199 202 +3 ☔ View full report in Codecov by Sentry. |
would you mind putting @jangorecki (and yourself?) as CODEOWNERSnfor GLCI? |
@@ -68,3 +68,6 @@ | |||
# docs | |||
/man/openmp-utils.Rd @Anirban166 | |||
/Seal_of_Approval.md @tdhock | |||
|
|||
# GLCI | |||
.gitlab-ci.yml @jangorecki @ben-schwen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this part is unrelated to the issue that this PR is meant to resolve. Also I think any changes to codeowners shouls be discussed before putting other people into it. I would like to assign myself to ci file but knowing I won't have time for really maintaining it in near future, I would not do so.
I see Michael's comment just now which nicely asks about it. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jangorecki I agree, I probably should have asked before putting your name there. But I don't see it so much as a burden that you have to review everything, but more as documentation (other than git blame) and a chance for us to get your thoughts and feedback (when needed) on changes there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, sorry about that, I meant to require Jan's review before submitting here given the CODEOWNERS change.
And right, it's not a requirement for review, just that you're a better default assignee than me. What I had in mind is (1) PRs from Ben go to Jan for review (2) other PRs go to Ben for review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(FWIW, I was wondering if the above would be better served by doing @ben-schwen @jangorecki
instead of @jangorecki @ben-schwen
, but AFAICT there's no difference as both will be requested: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#example-of-a-codeowners-file)
Closes #6552
Apparently, we need to set the variable since otherwise it does not find gcc correctly
CI results