Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom data.frame classes redirected to as.data.frame before as.data.table #5700

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jangorecki
Copy link
Member

closes #5699

R/as.data.table.R Outdated Show resolved Hide resolved
@jangorecki jangorecki added this to the 1.16.0 milestone Dec 9, 2023
x
}
y = as.data.table(x)
test(2240.1, attr(y, "t1", TRUE), NULL)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test happens to fail from R CMD check but not when doing interactive test from cc()

@jangorecki jangorecki added the WIP label Dec 9, 2023
@MichaelChirico MichaelChirico marked this pull request as draft February 19, 2024 02:45
@MichaelChirico MichaelChirico modified the milestones: 1.16.0, 1.17.0 Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

as.data.table should remove extra attributes from extended data.frames
2 participants