Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

further relaxation to test 1590 given change in R-devel on ordering encodings #4494

Merged
merged 1 commit into from
May 26, 2020

Conversation

mattdowle
Copy link
Member

@mattdowle mattdowle commented May 26, 2020

Follow up to PR #4492. See code diff for comments.

@codecov
Copy link

codecov bot commented May 26, 2020

Codecov Report

Merging #4494 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4494   +/-   ##
=======================================
  Coverage   99.60%   99.60%           
=======================================
  Files          72       72           
  Lines       13918    13918           
=======================================
  Hits        13863    13863           
  Misses         55       55           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6bc553...a872849. Read the comment docs.

@mattdowle mattdowle merged commit cacdc92 into master May 26, 2020
@mattdowle mattdowle deleted the encoding_order_change_in_r_followup branch May 26, 2020 02:26
@jangorecki jangorecki modified the milestones: 1.12.11, 1.12.9 May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants