Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend not-in-scope error for when it might be an integer column #3589

Merged
merged 2 commits into from
May 23, 2019

Conversation

MichaelChirico
Copy link
Member

@MichaelChirico MichaelChirico commented May 23, 2019

Closes #697

@codecov
Copy link

codecov bot commented May 23, 2019

Codecov Report

Merging #3589 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3589      +/-   ##
==========================================
+ Coverage   97.63%   97.63%   +<.01%     
==========================================
  Files          66       66              
  Lines       12702    12705       +3     
==========================================
+ Hits        12401    12404       +3     
  Misses        301      301
Impacted Files Coverage Δ
R/data.table.R 97.68% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd236a0...f00aee7. Read the comment docs.

@codecov
Copy link

codecov bot commented May 23, 2019

Codecov Report

Merging #3589 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3589      +/-   ##
==========================================
+ Coverage   97.63%   97.63%   +<.01%     
==========================================
  Files          66       66              
  Lines       12702    12708       +6     
==========================================
+ Hits        12401    12407       +6     
  Misses        301      301
Impacted Files Coverage Δ
R/data.table.R 97.68% <100%> (ø) ⬆️
src/froll.c 100% <0%> (ø) ⬆️
src/frolladaptive.c 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd236a0...d2c70f7. Read the comment docs.

@mattdowle mattdowle changed the title Closes #697 -- extend not-in-scope error message for when it might be… Extend not-in-scope error for when it might be an integer column May 23, 2019
@mattdowle mattdowle added this to the 1.12.4 milestone May 23, 2019
@mattdowle mattdowle merged commit d394384 into master May 23, 2019
@mattdowle mattdowle deleted the integer_subset_error branch May 23, 2019 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consistency in 'i' for integer and logical types
2 participants