Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DLL version == package version check #3237

Merged
merged 2 commits into from
Dec 20, 2018
Merged

DLL version == package version check #3237

merged 2 commits into from
Dec 20, 2018

Conversation

mattdowle
Copy link
Member

#3056
Comments there.

@mattdowle mattdowle added this to the 1.12.0 milestone Dec 20, 2018
@codecov
Copy link

codecov bot commented Dec 20, 2018

Codecov Report

Merging #3237 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3237      +/-   ##
==========================================
+ Coverage   94.65%   94.65%   +<.01%     
==========================================
  Files          65       65              
  Lines       12098    12100       +2     
==========================================
+ Hits        11451    11453       +2     
  Misses        647      647
Impacted Files Coverage Δ
src/init.c 93.84% <100%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update feb4824...2b59e5b. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 20, 2018 •
edited
Loading

Codecov Report

Merging #3237 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3237      +/-   ##
==========================================
+ Coverage   94.65%   94.65%   +<.01%     
==========================================
  Files          65       65              
  Lines       12098    12100       +2     
==========================================
+ Hits        11451    11453       +2     
  Misses        647      647
Impacted Files Coverage Δ
src/init.c 93.84% <100%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update feb4824...0bb33c6. Read the comment docs.

@mattdowle mattdowle merged commit f1bac25 into master Dec 20, 2018
@mattdowle mattdowle deleted the binaryversion branch December 20, 2018 08:13
@mattdowle mattdowle mentioned this pull request Dec 20, 2018
Closed
@mattdowle mattdowle mentioned this pull request Jun 11, 2019
Closed
@MichaelChirico MichaelChirico mentioned this pull request May 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
1 participant
@mattdowle