Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

news item for removing split.data.table export #3083

Merged
merged 1 commit into from
Sep 28, 2018

Conversation

mattdowle
Copy link
Member

@mattdowle mattdowle commented Sep 28, 2018

Reverts #2921 and #2920
Discussion here too: #3081 (review)

Merging before review since getting the release to CRAN is pressing. revdep checks take one day cycle elapsed and Jan barely overlaps my timezone. If Jan or anyone has further comments, still make them please post-merge and there's still time (24hrs) to catch before hitting CRAN.

@mattdowle mattdowle added this to the 1.11.8 milestone Sep 28, 2018
@codecov
Copy link

codecov bot commented Sep 28, 2018

Codecov Report

Merging #3083 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3083   +/-   ##
=======================================
  Coverage   90.88%   90.88%           
=======================================
  Files          61       61           
  Lines       11804    11804           
=======================================
  Hits        10728    10728           
  Misses       1076     1076

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b839b9c...856ec02. Read the comment docs.

@mattdowle mattdowle merged commit 89d8156 into master Sep 28, 2018
@mattdowle mattdowle deleted the split_datatable_note branch September 28, 2018 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant