Merge branch 'governance' of https://github.com/Rdatatable/data.table …

…into governance
Rdatatable · Dec 14, 2023 · 1ef2f45 · 1ef2f45
2 parents c6a282e + d9a9c30
commit 1ef2f45
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/GOVERNANCE.md b/GOVERNANCE.md
@@ -81,14 +81,14 @@ Most decisions in the project happen by Consensus, which means that no active pe
 ## Pull Requests
 
 A pull request can be merged by any committer, if there is one approving review, and Consensus from active Reviewers and Committers. 
-* approving review must come from different person from author of PR.
+* approving review must come from someone other than the author of the PR.
 * approving review ideally comes from a reviewer of the affected files.
-* approving review can be same as committer who merges the PR.
+* approving review can and often will be by the committer who merges the PR.
 
 ## CRAN updates
 
 * Regular CRAN releases should ideally occur twice per year, and can include new features.
-* A hotfix/patch CRAN release should occur when CRAN asks for one, at which time the CRAN maintainer should post an issue on github, and ask others to help fix/prepare the release.
+* A hotfix/patch CRAN release should occur when CRAN asks for one, at which time the CRAN maintainer should post an issue on github, and ask others to help fix/prepare the release. It should not include new features.
 * Both kinds of releases should be discussed in an issue, and the release should happen only if there is Consensus among active Reviewers and Committers.
 * It is the responsibility of the CRAN maintainer to ensure quality prior to release. This includes CRAN checks, unit tests, performance tests, etc, and these tasks can be delegated to others.