Feature/update modules example #668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this example still triggers messages from R-devel CMD check after discussion with jmc, concluded that these may stem from the R side
commit 43e53b0 Merge: 886f5df a15ba45 Author: Dirk Eddelbuettel <edd@debian.org> Date: Tue Apr 11 13:20:10 2017 -0500 Merge pull request #663 from jimhester/exceptions_without_callstacks Added support for throwing exceptions without call stacks. commit a15ba45 Author: Jim Hester <james.f.hester@gmail.com> Date: Mon Apr 3 16:11:24 2017 -0400 Added support for throwing exceptions without call stacks.
Codecov Report
@@ Coverage Diff @@
## master #668 +/- ##
=======================================
Coverage 92.91% 92.91%
=======================================
Files 65 65
Lines 3303 3303
=======================================
Hits 3069 3069
Misses 234 234Continue to review full report at Codecov.
|
|
@jjallaire @kevinushey @thirdwing @nathan-russell : I take lack of screaming as silent consent and will fold this in tomorrow or the next, unless someone beats me to it. It only affects demo / test packages illustrating Modules (and Rcpp Classes) so it is unlikely to do any damage. |
|
LGTM! |
nathan-russell
approved these changes
Apr 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains updates to the two 'sub-packages' used for testing and demo:
inst/unit/testRcppModule/inst/unit/testRcppClass/The first (for Modules) is in good shape and updates the Modules example to current R 3.4.0 standards.
The second (for John's Rcpp Classes) is in less ideal shape, and still emits warning. John suspects these may come from R itself so this can still be committed.
[ I tried to squash-commit Jim's PR in so that this would be mergeable, seems like that failed. My master now has these two commit's cherried in, but I won't push that til I see some nodding or thumbs-up here. ]
[ Edit: Was able to sort it out here. It only affected the ChangeLog. ]