Ad-hoc fix for testthat's C entrypoint #1274
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background here. It all comes to this call that relies on
tools::package_native_routine_registration_skeleton
for the generation of registering code, but such function does not make any effort to detect the types of the extern declarations here. It's justvoid *
for every argument, which works without LTO, but generates a warning with LTO enabled.So in this patch we just substitute
void *
withSEXP
for the particular case of testthat's C entrypoint, to make the life of these users easier. We probably could apply this to every declaration, but this should be further investigated. We can revisit this if new reports come out with other functions.To test this:
and then compilation succeeds without warning.
Checklist
R CMD check
still passes all tests