Skip to content

Adding Rcpp signature attribute #1183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from
Closed

Adding Rcpp signature attribute #1183

wants to merge 0 commits into from

Conversation

traversc
Copy link
Contributor

Pull Request Template for Rcpp

Please explain the changes you want to apply to Rcpp, preferably in an issue ticket before you create a pull request. See the file Contributing and the other templates for details.

Checklist

  • Code compiles correctly
  • R CMD check still passes all tests
  • Prefereably, new tests were added which fail without the change
  • Document the changes by file in ChangeLog

@eddelbuettel
Copy link
Member

Can you please enable the flag allowing the repo that you sent the PR to to commit in your clone too? I have to push a fix to permit tests to pass.

@eddelbuettel
Copy link
Member

Alternatively you can also cherry-pick commit 04d8b03 from the pr/1183 branch I just pushed (and where I permitted myself to rebase and squash you four commits with identical commit message into one).

@traversc
Copy link
Contributor Author

Added, sorry about that.

@eddelbuettel
Copy link
Member

(Took me a moment to realize I needed to force-push as I had rebased. Done now. And then I fat-fingered the close button by accident. Sorry.)

Rev.dep run is progressing but it'll be some time tomorrow that we know more.

@eddelbuettel
Copy link
Member

Or maybe my force-push accidentally close this. Sorry. I'm just going to open a new one off the branch where I added the commit.

@eddelbuettel
Copy link
Member

#1184 is now in better shape after I arm-wrestled the codecov yaml file so that it no longer flags the PRs as failed on because coverage drops a little.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants