Skip to content

Conversation

@fletchgqc
Copy link
Contributor

@fletchgqc fletchgqc commented Sep 9, 2025

  • Mount ~/.claudebox/ssh read-write when it exists for persistent SSH state
  • Fall back to ~/.ssh read-only for backwards compatibility
  • Documentation with setup instructions for dedicated ClaudeBox SSH keys

Summary by Sourcery

Enable flexible SSH key mounting by preferring a dedicated ~/.claudebox/ssh directory with read-write access and falling back to ~/.ssh as read-only, and update documentation with setup instructions

New Features:

  • Add support for mounting ~/.claudebox/ssh into containers as a read-write directory for persistent SSH state

Enhancements:

  • Fallback to mounting the user’s ~/.ssh directory as read-only when no ClaudeBox SSH directory exists

Documentation:

  • Add README section explaining SSH directory configuration and setup for ClaudeBox keys

- Mount ~/.claudebox/ssh read-write when it exists for persistent SSH state
- Fall back to ~/.ssh read-only for backwards compatibility
- Support for known_hosts updates and SSH connection multiplexing
- Documentation with setup instructions for dedicated ClaudeBox SSH keys
- Use existing CLAUDEBOX_HOME environment variable for consistency
@sourcery-ai
Copy link

sourcery-ai bot commented Sep 9, 2025

Reviewer's Guide

This PR enhances SSH key management by detecting a dedicated ClaudeBox SSH directory for read-write mounting in the container, falling back to a read-only ~/.ssh mount for backwards compatibility, and updates the documentation to describe this behavior with setup instructions.

File-Level Changes

Change Details Files
Implement conditional SSH directory mounting logic in the Docker launch script
  • Remove hard-coded read-only ~/.ssh mount
  • Add check for non-empty $CLAUDEBOX_HOME/ssh and mount it read-write
  • Fall back to mounting $HOME/.ssh read-only when custom directory is absent
  • Include verbose debug logging for each mount decision
lib/docker.sh
Add documentation for flexible SSH key configuration
  • Include ~/.claudebox/ssh in storage overview
  • Explain recommended read-write ClaudeBox SSH directory and read-only fallback
  • Provide shell commands to create the directory, set permissions, and generate keys
README.md

Possibly linked issues

  • #123: The PR addresses the issue by documenting SSH key mounting, providing a dedicated ~/.claudebox/ssh directory, and clarifying ~/.ssh read-only fallback.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant