-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Best styling codeblock #66
Open
shafan
wants to merge
16
commits into
RatanShreshtha:main
Choose a base branch
from
shafan:feature/best_styling_codeblock
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Best styling codeblock #66
shafan
wants to merge
16
commits into
RatanShreshtha:main
from
shafan:feature/best_styling_codeblock
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A user should be able to set an unoptimized avatar image. When the site is compiled, the image will be optimized using Tera's function: resize_image.
A new `colorscheme` option is added with the capability to be always dark, always light, or automatic based on the user's browser setting.
For this, I moved the theme attribute from body to the html tag
Links must have a discernible name For icon link, show https://kittygiraudel.com/2020/12/10/accessible-icon-links/
For a best referencement
Title is H2 and input must have label
Academicons.css and fontawesome.css are not critical ressource. Web can defer the loading. Show https://web.dev/render-blocking-resources/
Recommandation of zola : https://www.getzola.org/documentation/content/syntax-highlighting/#styling-codeblocks with none user select the line number cells
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recommandation of zola : https://www.getzola.org/documentation/content/syntax-highlighting/#styling-codeblocks