Enable allowed external iframe src's #985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 17, 2024 12:21
sra405
temporarily deployed
to
previews/enable-external-iframes
GitHub Actions
Inactive
|
|
Contributor
Author
|
Allows iframes to be embedded if they're on the same domain as the editor or on |
floehopper
added a commit
that referenced
this pull request
May 9, 2024
### Added - Support to enable embedding iframes in HTML projects from in-house domains (#985) - Dispatch event when project identifier changes, e.g. after project is remixed (#2830) - Add `load_remix_disabled` attribute to web component (#992) ### Changed - Invalidate cached project when project is remixed (#1003) ### Fixed - Unit tests for `pyodide` runner (#976) - Remove broken `format` script (#991)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of project migration from trinket to the code editor some additional functionality is required. This PR enables iframes to be used from the same approved external sources list as used for href's and other src attributes. By expanding this to allow for self references (i.e. src with a value the same as the
PUBLIC_URL) users can embed other projects they (or we) own in iframes into their projects