Refactor SidebarPanel to pass in buttons as elements #1271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamiebenstead
temporarily deployed
to
previews/1271/merge
GitHub Actions
Inactive
jamiebenstead
temporarily deployed
to
previews/1271/merge
GitHub Actions
Inactive
jamiebenstead
temporarily deployed
to
previews/1271/merge
GitHub Actions
Inactive
jamiebenstead
temporarily deployed
to
previews/1271/merge
GitHub Actions
Inactive
loiswells97
reviewed
Nov 6, 2025
src/components/Menus/Sidebar/InstructionsPanel/InstructionsPanel.jsx
Outdated
Show resolved
Hide resolved
loiswells97
reviewed
Nov 6, 2025
loiswells97
reviewed
Nov 6, 2025
jamiebenstead
temporarily deployed
to
previews/1271/merge
GitHub Actions
Inactive
loiswells97
reviewed
Nov 6, 2025
| } = props; | ||
| const isMobile = useMediaQuery({ query: MOBILE_MEDIA_QUERY }); | ||
|
|
||
| const buttonNodes = React.Children.toArray(buttons); |
Contributor
There was a problem hiding this comment.
Can this go too if we're insisting it's an array in the proptypes?
loiswells97
approved these changes
Nov 6, 2025
Contributor
loiswells97
left a comment
loiswells97
left a comment
There was a problem hiding this comment.
Nice one, thanks for putting up with my prevaricating over the best approach 😅
jamiebenstead
deleted the
Refactor-SidebarPanel-to-pass-buttons-as-elements
branch
Merged
patch0
added a commit
that referenced
this pull request
Nov 17, 2025
### Added - Font-family variables that can be used to customise the sans-serif and monospace fonts used in the editor (#1264) - Material symbols font to web component preview page since the Design System depends on this (#1261) - Ability for plugins to add buttons to the SidebarPanel header (#1270, #1271, #1274) - Prevent access to the session from within the editor (#1275) ### Changed - Changed the horizontal scrollbar to show without needing to scroll to the bottom of the editor window (#1257) - Updated Design System react to v2.6.2 (#1261) - Changed SidebarPanel to accept an array of buttons (#1270) - Changed SidebarPanel to use an array of buttons as elements (#1271) - Changed default-width and min-width on SidebarPanel (#1273) ### Fixed - Styling design system components used in the web component (#1263) - Sidebar panel overflow for plugins (#1266, #1269) - Extra border around code output in the instructions panel (#1253) - Line numbering alignment in code blocks in the instructions panel (#1259) - Extra lines added at the start of some code blocks (#1267)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/RaspberryPiFoundation/digital-editor-issues/issues/991