Fix dynamic pyodide switching with multiple files #1097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_switching_with_multiple_files
loiswells97
temporarily deployed
to
previews/1097/merge
GitHub Actions
Inactive
loiswells97
temporarily deployed
to
previews/1097/merge
GitHub Actions
Inactive
loiswells97
temporarily deployed
to
previews/1097/merge
GitHub Actions
Inactive
loiswells97
temporarily deployed
to
previews/1097/merge
GitHub Actions
Inactive
| ); | ||
| if (hasSkulptOnlyModules || senseHatAlwaysEnabled) { | ||
| setUsePyodide(false); | ||
| break; |
Contributor
There was a problem hiding this comment.
Good solution
Why did you decide to put "break" here?
Contributor
There was a problem hiding this comment.
This is to break out of looping over the components when one is found containing skulpt-only modules. The problem we were having only happened if are multiple components ("files"). If there was a file with skulpt-only imports it would switch to skulpt, but then if it found another file without skulpt-only imports afterwards it would switch back to pyodide and then the code wouldn't run. So we should break out of the loop as soon as we find a file with a skulpt-only import, as we already have enough information to know we need to use skulpt.
loiswells97
temporarily deployed
to
previews/1097/merge
GitHub Actions
Inactive
loiswells97
temporarily deployed
to
previews/1097/merge
GitHub Actions
Inactive
KristinaDudnyk
approved these changes
Oct 9, 2024
Contributor
KristinaDudnyk
left a comment
KristinaDudnyk
left a comment
There was a problem hiding this comment.
Amazing work Lois👏👏👏
loiswells97
deleted the
issues/1095-Fix_dynamic_pyodide_switching_with_multiple_files
branch
Merged
loiswells97
added a commit
that referenced
this pull request
Oct 22, 2024
## [0.28.0] - 2024-10-22 ### Added - PyodideWorker setup for the editor (#1104) - Enabling `pyodide` support in the web component (#1090) - `Pyodide` `matplotlib` support (#1087) - Tests for running simple programs in `pyodide` and `skulpt` (#1100) - Fall back to `skulpt` if the host is not `crossOriginIsolated` (#1107) - `Pyodide` `seaborn` support (#1106) - `Pyodide` module caching (#1113) ### Changed - Upgrade to `webpack 5` (#1096) - Bump `pyodide` to `v0.26.2` (#1098) - Updated the ImportErrors message (#1105) - In ErrorMessage component added the way to display html elements in string (#1105) ### Fixed - Dynamic runner switching with more than one `python` file (#1097) - Pyodide running the correct file (`main.py`) when there are multiple `python` files (#1097) - Build to include public files (#1112) - Persisting choice of tabbed/split view when running `python` code (#1114)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed?
pyodidewhen there are multiple filescloses #1095