Skip to content

Persist user code when remixing project #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 21, 2022
Merged

Persist user code when remixing project #35

merged 8 commits into from
Mar 21, 2022

Conversation

create-issue-branch[bot]
Copy link
Contributor

@create-issue-branch create-issue-branch bot commented Mar 17, 2022 •
edited by ArayB
Loading

Expect project data to be sent with remix request.
Use submitted data to populate remixed components.

closes #34

@raspberrypigithubbot
Copy link

@raspberrypigithubbot
Copy link

ArayB added 4 commits March 17, 2022 12:35
@ArayB
Use submitted project data when remixing
cd8c702 
Ensure that component information is taken from params when remixing a
project.
This allows any changes a user has made to a project before remixing to
be persisted.
@ArayB
Fix rubocop issues
c24957d
@ArayB
Alias method
633935f
@ArayB
Remove alias as it does not work
2da23b9 
Run tests in random order
@raspberrypigithubbot
Copy link

@ArayB ArayB marked this pull request as ready for review March 17, 2022 15:32
patch0
patch0 requested changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@patch0 patch0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there might be a few small things to alter :)

@raspberrypigithubbot
Copy link

@raspberrypigithubbot
Copy link

@raspberrypigithubbot
Copy link

@ArayB ArayB merged commit c573f85 into main Mar 21, 2022
@ArayB ArayB deleted the issues/34-Persist_user_code_when_remixing_project branch March 21, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patch0 patch0 patch0 approved these changes

+1 more reviewer

@ArayB ArayB ArayB left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Persist user code when remixing project

3 participants

@raspberrypigithubbot @patch0 @ArayB