feat: add more navigation shortcuts#9523
Merged
maribethb merged 1 commit intoRaspberryPiFoundation:add-screen-reader-support-experimentalfrom Dec 10, 2025
Merged
Conversation
gonfunko
approved these changes
Dec 10, 2025
github-actions
bot
added
PR: feature
Contributor
Author
|
Going to change the behavior of page down per the comment, but i'll do that in a follow up PR |
maribethb
merged commit 12da1fb
into
RaspberryPiFoundation:add-screen-reader-support-experimental
13 of 15 checks passed
BenHenning
reviewed
Dec 12, 2025
| const connection = inputs[inputs.length - 1].connection; | ||
| if (!connection || !(connection instanceof RenderedConnection)) | ||
| return false; | ||
| getFocusManager().focusNode(connection); |
Collaborator
There was a problem hiding this comment.
Does this make it possible to focus a connection that can't be navigated to normally @maribethb @gonfunko?
Contributor
There was a problem hiding this comment.
Hmm, perhaps. It might not be a bad idea to check canBeFocused() first or filter the input list on that basis; I think in some cases we'd actually want to focus the connected block of the connection (this is the main place I can think of where this might happen; empty input connections and statement connections are both valid, but a filled input connection is not IIRC)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes most of #9498 pending a question I asked there
Proposed Changes
Adds the navigation shortcuts described in issue
Reason for Changes
Test Coverage
Tests included, plus manual testing
Documentation
Additional Information