feat: Include parent category in verbose block descriptions#9522
Merged
gonfunko merged 3 commits intoadd-screen-reader-support-experimentalfrom Dec 10, 2025
Merged
feat: Include parent category in verbose block descriptions#9522gonfunko merged 3 commits intoadd-screen-reader-support-experimentalfrom
gonfunko merged 3 commits intoadd-screen-reader-support-experimentalfrom
Conversation
BenHenning
approved these changes
Dec 10, 2025
Collaborator
BenHenning
left a comment
BenHenning
left a comment
There was a problem hiding this comment.
Thanks @gonfunko! This generally LGTM though obviously there are CI fixes to address likely due to the circular import. If you'd like me to take another review pass after those are fixed then please ping me and I can take a quick look.
| } | ||
|
|
||
| /** | ||
| * Returns the colour of this category. |
Collaborator
There was a problem hiding this comment.
Nit: line fix to address for this block.
gonfunko
merged commit 4622cf5
into
add-screen-reader-support-experimental
7 of 8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #9499
Proposed Changes
This PR adds blocks' parent category to their verbose description in order to better orient users. By default each category is searched through to see if the block is part of it; if no match is found (e.g. if the block is part of a dynamic category) then matching falls back to checking the block's color against each category's color.